Skip to content

Calculate minimal diffs before updating Html buffer#12256

Merged
davidwengier merged 1 commit intodotnet:mainfrom
davidwengier:UpdateHtmlBufferWithMinimalChanges
Sep 23, 2025
Merged

Calculate minimal diffs before updating Html buffer#12256
davidwengier merged 1 commit intodotnet:mainfrom
davidwengier:UpdateHtmlBufferWithMinimalChanges

Conversation

@davidwengier
Copy link
Member

Fixes #12255

Turns out my lazy approach of "Well, we have the whole string, no point doing extra work" backfired, and the text snapshot change tracking couldn't handle it.

@davidwengier davidwengier requested a review from a team as a code owner September 23, 2025 05:55
@davidwengier
Copy link
Member Author

/backport to release/dev18.0

@github-actions
Copy link
Contributor

Started backporting to release/dev18.0: https://github.com/dotnet/razor/actions/runs/17937044057

Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

davidwengier added a commit that referenced this pull request Sep 23, 2025
…#12257)

Backport of #12256 to release/dev18.0

/cc @davidwengier

## Customer Impact

## Regression

- [ ] Yes
- [ ] No

[If yes, specify when the regression was introduced. Provide the PR or
commit if known.]

## Testing

[How was the fix verified? How was the issue missed previously? What
tests were added?]

## Risk

[High/Medium/Low. Justify the indication by mentioning how risks were
measured and addressed.]
@davidwengier davidwengier merged commit a75ef2f into dotnet:main Sep 23, 2025
11 checks passed
@davidwengier davidwengier deleted the UpdateHtmlBufferWithMinimalChanges branch September 23, 2025 19:49
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Sep 23, 2025
@davidwengier davidwengier modified the milestones: Next, 18.3 Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CSS statements with @ are not parsed correctly in Razor

2 participants